This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 19/31] Remove hidden_def and hidden_proto from cvt functions

From: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
To: <libc-alpha at sourceware dot org>
Date: Sun, 20 Oct 2019 22:55:42 -0300
Subject: Re: [PATCH 19/31] Remove hidden_def and hidden_proto from cvt functions
References: <20191015190529.11559-1-gabriel@inconstante.net.br> <20191015190529.11559-20-gabriel@inconstante.net.br>

On Tue, 15 Oct 2019, Gabriel F. T. Gomes wrote:
>
>Some *cvt functions are not called from within libc, yet they use
>hidden_def and hidden_proto.  This patch cleans this up and adds
>attribute_hidden to the declarations, for architectures that need it.

As I mentioned on a reply to Florian, I tested this patchset with
build-many-glibcs.py and I found another error (besides the one that
Florian pointed out).  The error is caused by this patch (on at least
s390x and alpha), but the patch is actually not needed, at all. :/

I'll send v2 without it and adapted for its absence. :)

References:
- [PATCH 00/31] Add IEEE long double <-> string functions for powerpc64le
  - From: Gabriel F. T. Gomes
- [PATCH 19/31] Remove hidden_def and hidden_proto from cvt functions
  - From: Gabriel F. T. Gomes

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]