This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4] Remove finite-math tests



On 16/07/2019 15:19, Adhemerval Zanella wrote:
> 
> 
> On 26/06/2019 10:59, Wilco Dijkstra wrote:
>> Remove the finite-math tests from the testsuite - these are no longer
>> useful after removing math-finite.h header.
>>
>> Passes buildmanyglibc, build&test on x86_64 and AArch64.
>>
>> 2019-06-26  Wilco Dijkstra  <wdijkstr@arm.com>
>>
>>         * math/Makefile: Update to remove finite-math tests.
>>         * math/gen-libm-test.py: Remove setting of NON_FINITE.
>>         * math/libm-test-driver.c: Remove TEST_FINITE, flag_test_finite.
>>         * math/libm-test-support.h: Remove flag_test_finite declartion.
> 
> s/declartion/declaration
> 
>>         * math/libm-test-support.c: Remove NON_FINITE support.
>>         * math/test-finite-macros.c: Remove file.
>>         * math/test-math-finite.h: Likewise.
>>         * math/test-math-inline.h: Remove TEST_FINITE.
>>         * math/test-math-no-finite.h : Remove file.
>>         * math/test-math-vector.h: Remove TEST_FINITE.
>> 	* math/test-signgam-finite.c: Remove test.
>>         * math/test-signgam-finite-c11.c: Likewise.
>>         * math/test-signgam-finite-c99.c: Likewise.
> 
> LGTM with just one modification regarding TEST_EXCEPTIONS below.
> 
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

I chatted with Wilco and I will commit this patch shortly with the
small modification I pointed out on his behalf.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]