This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH 2/3] elf: avoid redundant sort in dlopen
- From: David Kilroy <David dot Kilroy at arm dot com>
- To: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Thu, 17 Oct 2019 10:33:19 +0000
- Subject: [PATCH 2/3] elf: avoid redundant sort in dlopen
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xcum8Zg9CSNnsbl8AxSTWmx4Wev2HJBiGCYHAg6Fitc=; b=P57y05FIlB+HB7eQ/9YOZrCgjluo+GBuaER3nCMZMKbCRnH6dUkMOsDfz9htmtt8nqWjCIqn49d5hkxc2Lfm72cPmFgMhuRMMDTVoIwpTgEV5/PLztlan6RwlFzcVX1sX0WsuH9KZwBan1OYX6VX2RQQUDFdmIQujTqepNOqOP+boalWfKCUg7G7aeDbmMGBwh67GkzQjH9Fu3VvZYzZgnPLbO8plgo5f08yYRXamlqjbIaRSCBW9qMLdQMTTANcIHW6CclecYb1i/rhkDktyXz11569EEy5EguHHx0MiGfCcL/jb3maji5Jt6Eol9S0SrYIJGYemulV+6NsTutCkQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R3lfYOOd+c0O5bz9kBj5Rh7qdf7pGQOlbZRcXzje0cjQqCNeJi6CJbgBi0KyAGYGR4mGUNDHEXUvnTezS/cypGhBm52/Y6uuiqbFLfzpQOBFEqQPMvyE+SZ9OP9iXzAw1cflB/HbubyoTMFGUu0RWi3DhyP3ywREGAAE8kqMkD8rtbfGpBcF+530mC7sWVIsLxDTS5zoHatIfVPoIlTurV+aR9jzrZCME77W+f9jZhQDobPEglnoYk/dFdqVWPPcrg95eC0JsU+9YCMKAUDc+LyKj2l3gd85LhuSDPB7IP5QkkGgyxrp3wI4pqjG+pMk2pfKLG/6Vm/d+Q9ypZXjGw==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=David dot Kilroy at arm dot com;
- References: <cover.1571301957.git.david.kilroy@arm.com>
l_initfini is already sorted by dependency in _dl_map_object_deps(),
so avoid sorting again in dl_open_worker().
Tested by running the testsuite on x86_64.
---
elf/dl-open.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/elf/dl-open.c b/elf/dl-open.c
index 7fcfdc0..25e8fb0 100644
--- a/elf/dl-open.c
+++ b/elf/dl-open.c
@@ -326,7 +326,6 @@ dl_open_worker (void *a)
l = new->l_initfini[++j];
}
while (l != NULL);
- _dl_sort_maps (maps, nmaps, NULL, false);
int relocation_in_progress = 0;
--
2.7.4