This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] ldconfig: handle .dynstr located in separate segment (bug 25087)
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 16 Oct 2019 12:34:45 +0200
- Subject: Re: [PATCH] ldconfig: handle .dynstr located in separate segment (bug 25087)
- References: <mvmsgo1q758.fsf@suse.de>
* Andreas Schwab:
> + && dyn_entry->d_un.d_val < segment->p_vaddr + segment->p_filesz)
> + dynamic_strings = (char *) (file_contents + dyn_entry->d_un.d_val - loadoff);
I think these lines are too long. I also suspect that the condition
should be written as
dyn_entry->d_un.d_val - segment->p_vaddr < segment->p_filesz
But in principle, the change looks fine.
Is it possible to write a test case for bug 25087?
Thanks,
Florian