This is the mail archive of the
mailing list for the glibc project.
[PATCH] nptl: Document AS-safe functions in cancellation.c.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 4 Oct 2019 16:01:39 -0400
- Subject: [PATCH] nptl: Document AS-safe functions in cancellation.c.
In a recent conversation with Mathieu Desnoyer he pointed out that
because write is AS-safe all the wrappers around write should be
also AS-safe. We don't spell that out explicitly in the comments
for __pthread_enable_asynccancel and __pthread_disable_asynccancel
so I added them here.
OK for master?
8< --- 8< --- 8<
Document in comments that __pthread_enable_asynccancel and
__pthread_disable_asynccancel must be AS-safe in general with
the exception of the act of cancellation.
ChangeLog | 5 +++++
nptl/cancellation.c | 8 ++++++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index bdd97f0606..716f912c40 100644
@@ -1,3 +1,8 @@
+2019-10-04 Carlos O'Donell <email@example.com>
+ * nptl/cancellation.c: Document that all functions here must be
+ AS-safe because they wrap AS-safe functions.
2019-10-03 Leandro Pereira <firstname.lastname@example.org>
* elf/dl-load.c: Use __pread64_nocancel() instead of __lseek()+
diff --git a/nptl/cancellation.c b/nptl/cancellation.c
index 7712845561..ffe5b78b18 100644
@@ -24,7 +24,9 @@
/* The next two functions are similar to pthread_setcanceltype() but
more specialized for the use in the cancelable functions like write().
- They do not need to check parameters etc. */
+ They do not need to check parameters etc. This function must be
+ AS-safe, with the exception of the actual cancellation, because they
+ are called by wrappers around AS-safe functions like write().*/
@@ -59,7 +61,9 @@ __pthread_enable_asynccancel (void)
+/* This function must be AS-safe, with the exception of the actual
+ cancellation, because they are called by wrappers around AS-safe
+ functions like write().*/
__pthread_disable_asynccancel (int oldtype)