This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Y2038: Include proper header to provide support for struct timeval on HURD
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Lukasz Majewski <lukma at denx dot de>
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>, Alistair Francis <alistair23 at gmail dot com>, Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Florian Weimer <fweimer at redhat dot com>, Carlos O'Donell <carlos at redhat dot com>, Stepan Golosunov <stepan at golosunov dot pp dot ru>, Florian Weimer <fw at deneb dot enyo dot de>, Zack Weinberg <zackw at panix dot com>
- Date: Wed, 2 Oct 2019 15:58:35 +0000
- Subject: Re: [PATCH] Y2038: Include proper header to provide support for struct timeval on HURD
- Ironport-sdr: VNI/mscZR88DXbsl1e1e4IW2MkzJjlxPMM3hPEKeNLO9wHFjvtgtXCR9kXLEu4hHOu/kR8fLmj xn/jE9QI8dFJXDaiy4HiqIPs3k9kqGs312ZuA9xqor1auGVYvTAd+TA3N2gMI+Q3vzC+cTshE/ 8G+Ycy+KJdEQ5o5+AYWv3QBc3/lvHoyTpkeFmylurtLBVdB66zTnvgfHzfoyRfAMucXV0Q2isR zdOb+cEgt4+EVlDTBlnf6XUX4nide28KOmuI6xHVe8a81ICajXC50Hf3iElgDbO6W9FvxK4xG5 xcw=
- Ironport-sdr: XSd+2swuMJr5J/oc5orgDEoziP98lITsL0AXL9mPbVeAjVtUwrcZcuUxHWOI0FibrTGsRiJd5U A1qoMG/uLz9WbSNXI49+DJ7CTnVjD+kWlqVnoBQddha4y4K+igZL34V2kp5Iw6IUzlOFTnNOp9 p7xphs7/8kD+XuaS4Gzpq4WY5AL0PzHuPl8L2A9BM7i+/qd7s9HVTbR7XjD1IuY2OffxL9L1Q/ ItM0bmsW2QXJKBzNWNkvq2YtyZriOy9KBUaNOah/uhrGiXLMoZyRKicJdOdSI0nUg2Ax5Dvtli t60=
- References: <20191002154949.22664-1-lukma@denx.de>
On Wed, 2 Oct 2019, Lukasz Majewski wrote:
> The HURD requires explicit inclusion of <bits/types/struct_timeval.h> to use
> struct timeval in ./include/time.h.
> For this particular glibc port, the proper header hasn't been included before
> inclusion of time.h.
>
> Tested with build-many-glibcs.py with i686-gnu and x86_64-linux-gnu:
>
> build-many-glibcs.py /home/lukma/work/glibc/glibc-many-build --keep all compilers i686-gnu
> build-many-glibcs.py /home/lukma/work/glibc/glibc-many-build --keep all glibcs i686-gnu
>
> Also run of xcheck on x86_64:
> ./src/configure --prefix=/usr
> make PARALLELMFLAGS="-j12" && make xcheck PARALLELMFLAGS="-j12"
>
> * include/time.h: Add #include <bits/types/struct_timeval.h>
OK, please commit.
--
Joseph S. Myers
joseph@codesourcery.com