This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Add TCP_TX_DELAY from Linux 5.3 to netinet/tcp.h
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Fri, 27 Sep 2019 08:43:36 -0400
- Subject: Re: Add TCP_TX_DELAY from Linux 5.3 to netinet/tcp.h
- References: <alpine.DEB.2.21.1909202028570.25525@digraph.polyomino.org.uk>
On 9/20/19 4:29 PM, Joseph Myers wrote:
> This patch adds the new TCP_TX_DELAY constant from Linux 5.3 to
> sysdeps/gnu/netinet/tcp.h.
>
> Tested for x86_64.
>
> 2019-09-20 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/gnu/netinet/tcp.h (TCP_TX_DELAY): New macro.
>
> diff --git a/sysdeps/gnu/netinet/tcp.h b/sysdeps/gnu/netinet/tcp.h
> index 1a164a9649..41ca11b5f5 100644
> --- a/sysdeps/gnu/netinet/tcp.h
> +++ b/sysdeps/gnu/netinet/tcp.h
> @@ -79,6 +79,7 @@
> #define TCP_INQ 36 /* Notify bytes available to read
> as a cmsg on read. */
> #define TCP_CM_INQ TCP_INQ
> +#define TCP_TX_DELAY 37 /* Delay outgoing packets by XX usec. */
>
> #define TCP_REPAIR_ON 1
> #define TCP_REPAIR_OFF 0
>
OK for master. Matches UAPI headers as of da05b5ea12c1e50b2988a63470d6b69434796f8b.
Upstream linux duplicates the constant in two places, which looks like a bad design
to me.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.