This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts
- From: Alistair Francis <alistair23 at gmail dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 25 Sep 2019 15:52:41 -0700
- Subject: Re: [PATCH v2 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts
- References: <20190925003114.21546-1-alistair.francis@wdc.com> <mvma7asddtt.fsf@suse.de>
On Wed, Sep 25, 2019 at 12:39 AM Andreas Schwab <schwab@suse.de> wrote:
>
> On Sep 24 2019, Alistair Francis <alistair.francis@wdc.com> wrote:
>
> > diff --git a/sysdeps/unix/sysv/linux/generic/bits/stat.h b/sysdeps/unix/sysv/linux/generic/bits/stat.h
> > index 1565f3f8248..e580071d26c 100644
> > --- a/sysdeps/unix/sysv/linux/generic/bits/stat.h
> > +++ b/sysdeps/unix/sysv/linux/generic/bits/stat.h
> > @@ -40,7 +40,10 @@
> > /* Versions of the `xmknod' interface. */
> > #define _MKNOD_VER_LINUX 0
> >
> > -#if defined __USE_FILE_OFFSET64
> > +#if defined (__USE_FILE_OFFSET64) || defined (__INO_T_MATCHES_INO64_T)
> > +# if defined (__INO_T_MATCHES_INO64_T) && !defined (__OFF_T_MATCHES_OFF64_T)
>
> Our style is to omit the parens after defined.
Fixed in v3.
Alistair
>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."