This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] time: Add padding for the timespec if required

On Wed, 25 Sep 2019, Lukasz Majewski wrote:

> > > > +#if __WORDSIZE == 64 \
> > > > +  || (defined __SYSCALL_WORDSIZE && __SYSCALL_WORDSIZE == 64) ||
> > > > \
> > > > +  __TIMESIZE == 32  
>          ^^^^^^^^^^^^^^^^^ - this may be a bit problematic as 32 bit
>          systems (with __TIMESIZE == 32) gain support for 64 bit time
>          (so the Y2038 problem is solved).
> 	 Those systems also would require padding (the code below).
> 	 However, I do guess that allowing such systems to have the
> 	 extra padding after this patch (by removing __TIMESIZE==32
> 	 condition) is not an option for now (and shall be done in the
> 	 same commit which introduces -D_TIME_BITS=64 support to glibc)
> 	 ?

Yes, support for _TIME_BITS=64 should end up as one large commit that adds 
all the header support, all the function exports and symbol versions, all 
the ABI baseline updates and all the documentation.  (It may well be split 
into several pieces to review, but should still end up as one commit to 
avoid intermediate states where some interfaces have _TIME_BITS=64 support 
and some don't, so compiling with _TIME_BITS=64 gives a broken ABI.)

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]