This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] time: Add padding for the timespec if required
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Alistair Francis <alistair dot francis at wdc dot com>
- Cc: <libc-alpha at sourceware dot org>, <alistair23 at gmail dot com>
- Date: Wed, 25 Sep 2019 00:57:07 +0000
- Subject: Re: [PATCH 2/2] time: Add padding for the timespec if required
- Ironport-sdr: vt2db+ChE0ei6FBoyocdEtK+wzqfHk4ApDCgtxxF+p044dcMD4pPYSLbNyyfbmufFoN61L4nrn Pvj+tLsRuEAuyrgIjariJhPtsjGjGBT3GmurkL3xDWYwtQUV0Th8jsGVDtcovEx+RNvxdHRqBf Jyr3WWti2rNlW+QhY+FpoFgaoPF/vxoVv4AGdOkWV4ZCnjjujumKJb+PFtbWvBWsTbv4Pfc4pt mBBP+GUSj6NtEUu8KHelTcJRGzbew88WV8QdQnKdu62/gsUQTdHLVnL0nQ+N+3/NErjT+ZbSM6 Vbc=
- Ironport-sdr: YYNdAOOw251+GQzREKPQ7mqt+kt67aJbB2lCPO+0Y3CbVcBdyIIzEHsJWVNdiBLjjzEW1213Mv ArvqQbOiGdp5osLdgmaXlZ6D5fhI4tXUyTGbWuWJ8i4czuxnptxC2IY7Vqvck6Y05fP/d1n5BI YOK5FjZ6kNr+C9dPuo8MiZBFpJQ6W4GpGDYKNa0gTzgLu0ts4T2501EAroKTVmAOPglbZhzMLX Vmi1IS+maXm/gqEj+DrF9h95xFOYCRKHEgDvlCd/vHkjaWi+JDE1YF17ug6PA5DMW4HnBOwoFJ mJk=
- References: <20190925002903.15928-1-alistair.francis@wdc.com> <20190925002903.15928-2-alistair.francis@wdc.com>
On Tue, 24 Sep 2019, Alistair Francis wrote:
> +#if __WORDSIZE == 64 \
> + || (defined __SYSCALL_WORDSIZE && __SYSCALL_WORDSIZE == 64) || \
> + __TIMESIZE == 32
|| goes at start of line, not at end of line.
> __syscall_slong_t tv_nsec; /* Nanoseconds. */
> +#else
> +# if __BYTE_ORDER == __BIG_ENDIAN
> + int: 32; /* Padding */
> + long int tv_nsec; /* Nanoseconds */
> +# else
> + long int tv_nsec; /* Nanoseconds */
> + int: 32; /* Padding */
> +# endif
> +#endif
The comment formatting in the other cases, with ". " ('.' and two spaces)
at end of comment, is correct GNU style.
The patch is OK with those fixes once the <bits/endian.h> changes are
reviewed and checked in.
--
Joseph S. Myers
joseph@codesourcery.com