This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] Script to generate ChangeLog-like output from git log
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- Cc: libc-alpha at sourceware dot org, carlos at redhat dot com, joseph at codesourcery dot com
- Date: Fri, 20 Sep 2019 11:49:20 -0700
- Subject: Re: [PATCH] Script to generate ChangeLog-like output from git log
- References: <firstname.lastname@example.org> <20190920135044.2b3939e1@tereshkova>
On 20/09/19 9:50 AM, Gabriel F. T. Gomes wrote:
> Thank you so much for doing this. The patch looks good to me, although I
> think it would be a little bit better to use the commit date, instead of
> the author date, because it would make the order of the commits look a bit
> more sane and it would more closely resemble what we have today.
> To achieve this, you could apply the following patch on top of yours.
> If you think that's nice, you have my OK to commit it with the change. If
> you would prefer to have the Author Date in the ChangeLog output, I'm also
> OK with it! Thanks again!
Thanks, that is perfect, I've added it in and committed it.
>> + # Consume everything up to the ending brace of the function.
>> + (cur, loc) = self.fast_forward_scope(cur, op, loc)
> Neat! I run this with extra printfs in the code, and notice that the
> whole function implementation goes into the 'contents' field, which can
> later be compared by 'compare_trees'.
Yeah there's some cool stuff we can do with this, maybe some static
analysis on diffs to do some simple checks on the changed code. In a
way, ChangeLog generation is sort of a stepping stone to this.