This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] time: Create a endian_t.h headerfile

On Fri, 20 Sep 2019, Zack Weinberg wrote:

> On Thu, Sep 19, 2019 at 7:34 PM Joseph Myers <> wrote:
> >
> > If anything, I think the cleanest naming would be to have <bits/endian.h>
> > be the architecture-independent header that defines these three macros and
> > includes <bits/endian-arch.h>, where the existing <bits/endian.h> headers
> > that define __BYTE_ORDER all get renamed to <bits/endian-arch.h>.  So
> > you'd need to add bits/endian-arch.h to the "headers" setting in
> > string/Makefile.
> I believe I wrote that patch already, in fact, as part of my
> installed-headers cleanups series:
>  Unlike a
> lot of those patches, it should be low-risk for application breakage
> and applicable independently.

Yes, that's the sort of thing I'd expect (and I had a comment on it in 
<>).  (This is 
not a review.  When retesting this patch it would be necessary to check if 
any new includes of <endian.h> have been added to installed headers that 
need updating as well.)

I should explicitly note that, while it's easy to think of possible 
followup cleanups in this area, it's best *not* to combine such cleanups 
with this patch in order to keep it of a reasonable size and complexity.

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]