This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function

From: Joseph Myers <joseph at codesourcery dot com>
To: Lukasz Majewski <lukma at denx dot de>
Cc: Alistair Francis <alistair23 at gmail dot com>, Zack Weinberg <zackw at panix dot com>, Arnd Bergmann <arnd at arndb dot de>, Alistair Francis <alistair dot francis at wdc dot com>, GNU C Library <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Florian Weimer <fweimer at redhat dot com>, Carlos O'Donell <carlos at redhat dot com>, Stepan Golosunov <stepan at golosunov dot pp dot ru>
Date: Wed, 18 Sep 2019 21:45:40 +0000
Subject: Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
Ironport-sdr: euTSRCGQeMk6i3wtM8TBFperpSOejfMa8Job3rfxZsz6M0Xtyx599KLEOB84Wh34TpJm/LfIjK jwFzOBVHBT2BXqFrJKbfBMpi23ZkKD6PdBKzagrK992h8WG88queWVM7wxOWM+Q68S0IsJCdZC AeSR1YuL71oE8a/6OCYcBE6bBw1/mcw+KBJo6TNa5SugWZm81oqrYe75S3xLRWH+R2WSVJoQox p+KMorEY/t66m1HyOaufxfQWZr5q5mZaiCJ2G+TW3PDzT3R+KOrym+/XQ4QuGVrDjkUC/RyYuA kiE=
Ironport-sdr: lg5cF7JR5xsoGthwAiMkOMzAFwRcqpDyB+CkdxuJqW9UJIcHw2/U6UTTnHOoM70vitdEGy8MYS Y5/3sakrDMyXKn4F6x/LQEePyN4jgGDhhL44jCWsdPUe7VOFnrmi5fR9KlICXLWpSjFBKnz/Ck Las9DSfXt16sdGqjoNHYEoH40pOFn+4WNW+131jouWWM4UE8SKRrW7L/Ge1vyOdMJzYeRk7go9 XyCc7X8YBzs15f2NRBMawpRNtUulIQnnjrdm86vLUuyrAqflcmoqGiln3BtdrPxH090gv4eKLt eeg=
References: <20190906145911.30207-1-lukma@denx.de> <CAKmqyKMdsVZg_ZS7fLTt23dy2vnZc1z85b_+8heiK-8UiqMx+g@mail.gmail.com> <alpine.DEB.2.21.1909062122220.30243@digraph.polyomino.org.uk> <CAKmqyKP=kmeJjcsDepetvsVrph3xJ7G8yQdNFNyX-wL2ZMtqmA@mail.gmail.com> <20190917121151.01629dad@jawa> <alpine.DEB.2.21.1909171332410.17687@digraph.polyomino.org.uk> <20190917175343.01715554@jawa> <alpine.DEB.2.21.1909171640200.25711@digraph.polyomino.org.uk> <CAKmqyKOXtCQ68G0DxEcesbKQCWGaXpvMV2SX-hzDdJJaQ+J_cA@mail.gmail.com> <alpine.DEB.2.21.1909181713340.18433@digraph.polyomino.org.uk> <20190918233721.43ebe10b@jawa>

On Wed, 18 Sep 2019, Lukasz Majewski wrote:

> Just one more question - am I correct that the above code will increase
> the overall sizeof(struct timespec) to 12 for machines with __WORDSIZE
> == 32 ?

It looks like that's a bug in the patch, indeed.  (The padding should 
*only* be added when __TIMESIZE == 64 in addition to the other conditions 
given, not when __TIMESIZE == 32.)

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Lukasz Majewski
- Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Alistair Francis
- Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Joseph Myers
- Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Alistair Francis
- Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Lukasz Majewski
- Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Joseph Myers
- Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Lukasz Majewski
- Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Joseph Myers
- Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Alistair Francis
- Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Joseph Myers
- Re: [PATCH v7 0/3] y2038: Linux: Introduce __clock_settime64 function
  - From: Lukasz Majewski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]