This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] Speedup various nptl/tst-mutex5 tests.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Stefan Liebler <stli at linux dot ibm dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 12 Sep 2019 10:15:49 -0400
- Subject: Re: [PATCH] Speedup various nptl/tst-mutex5 tests.
- References: <firstname.lastname@example.org>
On 9/12/19 8:16 AM, Stefan Liebler wrote:
> each of these tests - tst-mutex5, tst-mutex5a, tst-mutexpi5
> and tst-mutexpi5a - runs for 6s.
> do_test_clock is called three times, which tries to lock the mutex
> which times out after 2 seconds.
> This patch reduces the timeout to 0.3 seconds which leads to a
> runtime of roughly 0.9s for one tst-mutex5... invocation.
> As the nptl tests run in sequence, this patch saves roughly 20s of
> runtime for "make check".
> * nptl/tst-mutex5.c (do_test_clock): Reduce timeout.
Why is it safe to wait 0.3 seconds instead of 2 seconds?
Is the timeout being used in place of synchronization elsewhere?
We need a comment specifying if it's safe to lower the timeout