This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC PATCH 00/11] Library OS support
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Isaku Yamahata <isaku dot yamahata at gmail dot com>
- Cc: <libc-alpha at sourceware dot org>, <isaku dot yamahata at intel dot com>
- Date: Thu, 12 Sep 2019 00:10:32 +0000
- Subject: Re: [RFC PATCH 00/11] Library OS support
- Ironport-sdr: czEGhCr9dePmJEQ/AZ7WZRolhVaHDzvRLczRC9izbZ1yZWS+MgP4R6OFFTicmr6A6gBbBx6bcL pOqm9q+ic5oKLkhNOmUXM/AgKzWgWFCt07coCDfNuuafUq4F85C39Q+ccFcFtR/9x8Z7Ku7BI5 hhTex5PztK45WcMf3LZTq1tzLU7TRd22PWv5xAtPyX6w687XAcmf/0IQ6XqIU9LUgnu6JalL7u j/ckVKfabKvTfOH2RBMRkcWosg4MmHrDo8MKN3op4CkOOLElMPP8wFuFmyVTh5J+V42sCOycqe b2Y=
- Ironport-sdr: rSJRZyD2iJQi3EncJvhGa6UKn/ehcvOduIwhely/Jv1sNPKCauMVKaAWegOpUSa7JuzakA1yAK y3xNle++bR+ah0ddzDyi+hiKWm3XMsArDq4U0PrLqz0hxJebpfZWeABuPYOiAewaU29Qqz2OMm lXM7mR2JoFne10K6/sDdFZxpD2Qe7HqywkFj3YiDKo+1A44YEiwRKxT/+kvxc15kr1Z2/7Zg93 9ovhtDBQ/PSG2VG7NghOf1LxBaRr0hcnCaNvWAkJFod14l8scepG5T2n/SIbAyyYDSz/3otsgu 16U=
- References: <cover.1568219399.git.isaku.yamahata@gmail.com>
On Wed, 11 Sep 2019, Isaku Yamahata wrote:
> This patch is to add Library OS(LibOS in short) to glibc.
> This is the first version of patch series to support LibOS.
I don't see anything here about host triplets being used. I'd expect
x86_64-*-libos or similar (with consequent config.sub changes being
submitted to GNU config.git) but there's nothing to indicate that, and the
patch series is lacking documentation (NEWS, install.texi / regeneration
of INSTALL, other .texi files if applicable). I'd also expect any new OS
to have appropriate additions to build-many-glibcs.py. There are a great
many complications specific to existing GNU/Linux ABIs that ought to be
irrelevant in this case (compat support for old symbol versions,
enable-kernel support for different minimum kernel versions, etc.).
Given the modification of generic files, you should verify that installed
stripped shared libraries for e.g. x86_64-linux-gnu are byte-for-byte
identical before and after the patch (or justify them not being so if they
aren't identical - I'd expect justifications of the form "this file has
line numbers in assertions that change").
There should not be any __x86_64__ conditionals in generic files; the
sysdeps structure should be used as appropriate instead.
--
Joseph S. Myers
joseph@codesourcery.com