This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Add nocancel version of pread64()

On August 6th 2019, Carlos O'Donnel wrote:

>> 2019-08-05  Leandro Pereira  <>
>>        * sysdeps/generic/not-cancel.h: New macro.
>>        * sysdeps/unix/sysv/linux/not-cancel.h: New macro.
>>        * sysdeps/unix/sysv/linux/pread64_nocancel.c: Implement nocancel
>>        version of pread64.
>>        * sysdeps/unix/sysv/linux/Versions (GLIBC_PRIVATE): Add
>>        __pread64_nocancel.
>>        * sysdeps/unix/sysv/linux/Makefile: Reference pread64_nocancel.c.
> (...)
> I don't see a copyright disclaimer for you on file, and I'm going to
> follow up with you privately to see what we can do there to expedite
> the process so we can work on your patches as quickly as possible.  

With the exception of the boilerplate copied from existing glibc code
(essentially the patch adding the pread() syscall wrapper), the legally
significant changes are only the changes to use pread() instead of
seek()+read(); and those are less than around 15 lines of code.  This should
be fine according to FSFs guidelines.     

Since the changes are small, it falls under an "de minimis" exception rule
for open source contributions at Microsoft, making it a lot easier to
contribute this patch.  If we need to contribute larger changes, then we 
can work out the copyright paperwork.  (Or if I contribute changes as
a private individual, of course.)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]