This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ToT glibc build problem with ToT GCC


* Szabolcs Nagy:

> On 03/09/2019 11:12, Florian Weimer wrote:
>> * Szabolcs Nagy:
>> 
>>> On 30/08/2019 17:18, Florian Weimer wrote:
>>>>
>>>> localedef: Use initializer for flexible array member [BZ #24950]
>>>>
>>>
>>> i would mention that you put the struct in .rodata,
>>> that is a non-obvious change.
>> 
>> Please see below.
>> 
>>> i'm fine with using gcc extension for the initializer.
>>> i think the union solution is a bit safer though.
>>> either way, it would be nice to fix this build error.
>> 
>> I don't think this is a GCC extension.  I believe it's part of C99.
>
> iso c has this example:
>
> http://port70.net/~nsz/c/c11/n1570.html#6.7.2.1p21
>
> so the initializer relies on a gcc extension.

Okay, I stand corrected.

What about the updated commit message I sent earlier?  Shall I push
this?

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]