This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: ToT glibc build problem with ToT GCC
- From: Florian Weimer <fweimer at redhat dot com>
- To: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- Cc: nd <nd at arm dot com>, Carlos O'Donell <carlos at redhat dot com>, Martin Sebor <msebor at gmail dot com>, Steve Ellcey <sellcey at marvell dot com>, "libc-alpha\@sourceware.org" <libc-alpha at sourceware dot org>, "msebor\@redhat.com" <msebor at redhat dot com>
- Date: Tue, 03 Sep 2019 12:53:23 +0200
- Subject: Re: ToT glibc build problem with ToT GCC
- References: <486309d08583ed1c27a001d946205850b421f7ad.camel@marvell.com> <53b36206-3f07-432b-9d0f-02520debe4b8@gmail.com> <d96c9e5d-18f6-9c55-cd49-334c3d449a5b@redhat.com> <2e5c0137-4109-e7ce-8d1d-9c268e086f81@gmail.com> <f67a431b-0d15-644a-c5cd-8cf2ccf8e270@redhat.com> <87ef126bvu.fsf@oldenburg2.str.redhat.com> <ba965603-cc2a-3c53-4a1b-9edaf356f283@arm.com> <87mufq4og4.fsf@oldenburg2.str.redhat.com> <4679ba62-85c2-cc52-1a9d-5c75b3005344@arm.com> <87lfv5sn6h.fsf@oldenburg2.str.redhat.com> <de0c153a-fd8d-5147-9e62-8a37c6f2d22b@arm.com>
* Szabolcs Nagy:
> On 03/09/2019 11:12, Florian Weimer wrote:
>> * Szabolcs Nagy:
>>
>>> On 30/08/2019 17:18, Florian Weimer wrote:
>>>>
>>>> localedef: Use initializer for flexible array member [BZ #24950]
>>>>
>>>
>>> i would mention that you put the struct in .rodata,
>>> that is a non-obvious change.
>>
>> Please see below.
>>
>>> i'm fine with using gcc extension for the initializer.
>>> i think the union solution is a bit safer though.
>>> either way, it would be nice to fix this build error.
>>
>> I don't think this is a GCC extension. I believe it's part of C99.
>
> iso c has this example:
>
> http://port70.net/~nsz/c/c11/n1570.html#6.7.2.1p21
>
> so the initializer relies on a gcc extension.
Okay, I stand corrected.
What about the updated commit message I sent earlier? Shall I push
this?
Thanks,
Florian