This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v9] y2038: Introduce the __ASSUME_TIME64_SYSCALLS define
On Tue, Aug 27, 2019 at 5:55 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Tue, 27 Aug 2019, Alistair Francis wrote:
>
> > On Tue, Aug 27, 2019 at 12:35 PM Joseph Myers <joseph@codesourcery.com> wrote:
> > >
> > > On Tue, 27 Aug 2019, Zack Weinberg wrote:
> > >
> > > > I think that gets everything important. Neither the commit message
> > > > nor the comment needs to list all the new system calls.
> > >
> > > The syscalls need to be listed to make clear exactly what the interfaces
> > > covered by the macro are.
> >
> > I'm a little confused, should I change anything or leave the patch as is?
>
> My comments were on Zack's version (missing the list of syscalls). I
> believe Zack's version is not ready to go in as is but needs further
> changes for the issues I described (listing the syscalls and referring to
> the possibility that they may be suffixed or unsuffixed).
I will reread v8 and v9 and send another draft tomorrow.
zw