This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix posix/tst-regex by using ISO-8859 encoding for ChangeLog.8.
On 8/27/19 6:54 AM, Paul Eggert wrote:
> Stefan Liebler wrote:
>>>
>>> Better the test should be fixed to assume UTF-8, or, even better,
>>> not to rely on ChangeLog files for test data.
>>>
>>> zw
>>>
>>
>> Sure. Sounds fair. I've copied the old ChangeLog.8 file and use it
>> as a dedicated input-file for tst-regex. See attached patch.
>
> Better to do both, i.e., to not have the test cases rely on ChangeLog
> files, and to use UTF-8 in source files. Proposed patch attached.
> This patch has mixed encoding since it changes a file's encoding from
> Latin-1 to UTF-8, so it's compressed to prevent my email client from
> mangling it.
I don't know what you did with your attachments but whatever you did
makes it impossible for me to review them :-(
Normally my MUA will inline display text-style patches so I can comment
on them in a broad reply.
I've already ACK'd Stefan's other patch, since it splits out the test
input. The rest is orthogonal IMO.
FAOD I think you should have consensus to just clean all of this up
and switch to UTF-8. But they can go in after his change.
--
Cheers,
Carlos.