This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix posix/tst-regex by using ISO-8859 encoding for ChangeLog.8.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Stefan Liebler <stli at linux dot ibm dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 27 Aug 2019 14:41:14 -0400
- Subject: Re: [PATCH] Fix posix/tst-regex by using ISO-8859 encoding for ChangeLog.8.
- References: <6b0df162-d17a-ec1d-0fc0-728dc3a8ef9b@linux.ibm.com>
On 8/26/19 10:41 AM, Stefan Liebler wrote:
> Hi,
>
> the recent commit e6855a3bdfe147c52b29b5e7d70a95a8aa22ece0
> changed the encoding of ChangeLog.old/ChangeLog.8 from ISO-8859 to UTF-8.
> Unfortunately the test posix/tst-regex assumes the former encoding.
>
> This patch just changes the encoding back to ISO-8859.
> Furthermore Francesco Potortì is now written with 'ì' instead of 'i`'
> which leads to two further matches in the first call to test_expr.
>
> Bye
> Stefan
>
> ChangeLog:
>
> * ChangeLog.old/ChangeLog.8: Use ISO-8859 encoding.
Stefan, Thank you for trying to fix this. I think we should handle
it slightly different and set a precedent here.
Please copy ChangeLog.8 to tst-regex.in and use a test-specific input
file. I find it silly that we've been using ChangeLog.8 for anything.
To be clear I think we should:
* Leave the ChangeLog in UTF-8. -- This is for attribution only.
* Add a new tst-regex.in -- This is for testing only.
Likewise if you find anything else like this I'd say we split out the
inputs into test-specific inputs.
Any time we mix attribution and testing is bound to go wrong.
--
Cheers,
Carlos.