This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Status of build bots?
On 8/21/19 12:57 PM, Joseph Myers wrote:
> On Wed, 21 Aug 2019, Florian Weimer wrote:
>
>> * Joseph Myers:
>>
>>> 2019-08-21 Joseph Myers <joseph@codesourcery.com>
>>>
>>> * resolv/tst-resolv-ai_idn-latin1.c (do_test): Mark test
>>> unsupported with libidn2 before 2.0.5.
>>> * resolv/tst-resolv-ai_idn.c (do_test): Likewise.
>>
>> This patch looks reasonable to me. The test still runs on Fedora 30,
>> with libidn 2.2.0.
>
> Carlos, any comments, since you previously said these tests should fail
> with older libidn2?
>
No objection from my side. When I made my previous comments I had not
considered the impact they would have on build bots and CI setups.
We really should be aiming for clean results.
This patch looks good to me.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.