This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 10/12] Warn when gettimeofday is called with non-null tzp argument.

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Zack Weinberg <zackw at panix dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>, Joseph Myers <joseph at codesourcery dot com>, Florian Weimer <fweimer at redhat dot com>, Lukasz Majewski <lukma at denx dot de>, Alistair Francis <alistair23 at gmail dot com>, Stepan Golosunov <stepan at golosunov dot pp dot ru>, Arnd Bergmann <arnd at arndb dot de>
Date: Tue, 20 Aug 2019 12:06:17 -0700
Subject: Re: [PATCH 10/12] Warn when gettimeofday is called with non-null tzp argument.
References: <20190820132152.24100-1-zackw@panix.com> <20190820132152.24100-11-zackw@panix.com> <2dcf8274-e764-cb3b-2fba-c5a97a2ede4a@cs.ucla.edu> <CAKCAbMhR6A3=aujfz7x3uf34XkTOE1E_fKwKgOV4r2wFBEBZMQ@mail.gmail.com>

Zack Weinberg wrote:

-    memset (tz, 0, sizeof *tz);
+    memset (tz, 0, sizeof (struct timezone));

This change isn't necessary, and I prefer the previous version as it's easier to
audit.

I think you missed that this change also makes the type of `tz` be
`void *` (consistent with POSIX) so the older construct will not work
anymore.

zw


Ah, right you are. Sorry about the noise.

References:
- [PATCH 00/12] Y2038 preparation: use clock_[gs]ettime to implement the other time-getting and -setting functions
  - From: Zack Weinberg
- [PATCH 10/12] Warn when gettimeofday is called with non-null tzp argument.
  - From: Zack Weinberg
- Re: [PATCH 10/12] Warn when gettimeofday is called with non-null tzp argument.
  - From: Paul Eggert
- Re: [PATCH 10/12] Warn when gettimeofday is called with non-null tzp argument.
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]