This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] [MIPS] Raise highest supported EI_ABIVERSION value [BZ #24916]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Mihailo Stojanovic <mihailo dot stojanovic at rt-rk dot com>
- Cc: <libc-alpha at sourceware dot org>, "Maciej W . Rozycki" <macro at linux-mips dot org>, Carlos O'Donell <carlos at redhat dot com>, Dragan Mladjenovic <dragan dot mladjenovic at rt-rk dot com>
- Date: Tue, 20 Aug 2019 15:27:09 +0000
- Subject: Re: [PATCH v3] [MIPS] Raise highest supported EI_ABIVERSION value [BZ #24916]
- Ironport-sdr: L4Buu3O3OjlD62N9zUHS9x1fcyFZk3ak0RK484NPPLMoCLgEn+8C3pWFB26MS9yBt/TdkhWRZZ AfgNWlf/7kwebY6A//MnMqCQaGMGEldZAL0+60htNpRozUkmSGXmms4f/VYXpmDU0k2f2TYuQH AvircVJrRTjW4tpJxpNJ+F6Qm1ieApJyDkpZo3JRdiNVi2ts33Zvw51U6duI5rsj/6ulFyV9pc E/wc9aEIoSgqcheRDXsOYIKCT5cyn1UnWPPIqtSj6ZZdfv07ESdT9obetmQYysevjsGWbxvWEC ztU=
- Ironport-sdr: r16qdNKFCW0tpHVedCrtAFTebTBC5Qh3V/vnhVLQdVofxoUBvJzGSgOcZN2RNyLMCO/RJPP3V+ yDvtS+OZPdWzCtDEADX4NlXxZoobVFl0IDySdaxBEnie71EWaWQuOj/4ycUB/n2/ji9/wuQjOy P7VuNxrPk6k6vTHympbSkvAt47Rpe8gPSXDcYKmaPbSDR9H+EVcIcDwpQTIIMsEKHMqYAHv08t N5SreNezS2Irs8dOgctnrQKwciHcMVfX3mJTxFweTve2cmQFSsZkd3TnpAOjQSEgLBOueK0VV2 jYo=
- References: <1566312011-4112-1-git-send-email-mihailo.stojanovic@rt-rk.com>
On Tue, 20 Aug 2019, Mihailo Stojanovic wrote:
> Hello everyone,
>
> As suggested by Joseph here [1], this bumps the highest valid ABIVERSION
> value to ABSOLUTE ABI, which was overlooked in [2].
>
> New testcase loads the symbol from the GOT with the "lb" instruction
> so that the EI_ABIVERSION header field of the shared object is set
> to ABSOLUTE (it doesn't actually check the value of the symbol), and
> makes sure that the main executable is executed without "ABI version
> invalid" error.
Could you give details of how this was tested - did you test for all three
ABIs? (That's information that generally belongs in the proposed commit
message.)
> +CFLAGS-tst-undefined-weak.c: -O0
That's not how you set CFLAGS for a target. So presumably you don't need
-O0 at all?
> +#ifdef _ABIO32
I think the convention is to do
#include <sgidefs.h>
#if _MIPS_SIM == _ABIO32
rather than #ifdef on _ABI* macros.
--
Joseph S. Myers
joseph@codesourcery.com