This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 1/2] Refactor sigcontextinfo.h

From: Florian Weimer <fweimer at redhat dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org
Date: Thu, 15 Aug 2019 13:59:48 +0200
Subject: Re: [PATCH v2 1/2] Refactor sigcontextinfo.h
References: <20190801181534.8802-1-adhemerval.zanella@linaro.org>

I did this:

-#define GET_PC(ctx) ((intptr_t) (((ucontext_t *) \
+#define GET_PC(ctx) (1 + (intptr_t) (((ucontext_t *) \
 		     (ctx))->uc_mcontext.gregs[REG_RIP]))

And none of the existing x86-64 tests failed. 8-(

So I strongly urge you to add a test like the one below.  I can commit
it separately after your patch.  I still need to verify that it builds
on all architectures.

Thanks,
Florian

Attachment: p
Description: Text document

Follow-Ups:
- Re: [PATCH v2 1/2] Refactor sigcontextinfo.h
  - From: Adhemerval Zanella

References:
- [PATCH v2 1/2] Refactor sigcontextinfo.h
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]