This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC v4 07/24] time: Deprecate struct timezone members

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Alistair Francis <alistair dot francis at wdc dot com>, libc-alpha at sourceware dot org
Cc: arnd at arndb dot de, adhemerval dot zanella at linaro dot org, fweimer at redhat dot com, palmer at sifive dot com, macro at wdc dot com, zongbox at gmail dot com, alistair23 at gmail dot com
Date: Fri, 9 Aug 2019 18:20:03 -0700
Subject: Re: [RFC v4 07/24] time: Deprecate struct timezone members
References: <cover.1565398513.git.alistair.francis@wdc.com> <53894e78c91ed5e037077f7249b85cefe635ae1f.1565398513.git.alistair.francis@wdc.com>

Alistair Francis wrote:

-    int tz_minuteswest;		/* Minutes west of GMT.  */
-    int tz_dsttime;		/* Nonzero if DST is ever in effect.  */
+    int tz_minuteswest_dep;		/* Minutes west of GMT.  */
+    int tz_dsttime_dep;		/* Nonzero if DST is ever in effect.  */

These two members should be declared with __attribute_deprecated__. And once wedo that, do we still need to change their names? I don't recall any otherinstance of such name-changing.

If we do change their names, I suggest a more-obvious suffix than "_dep" (whichcould stand for a lot of things); "_deprecated" would be clearer.

Follow-Ups:
- Re: [RFC v4 07/24] time: Deprecate struct timezone members
  - From: Alistair Francis

References:
- [RFC v4 00/24] RISC-V glibc port for the 32-bit
  - From: Alistair Francis
- [RFC v4 07/24] time: Deprecate struct timezone members
  - From: Alistair Francis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]