Re: [PATCH 2/2] linux: Make profil_counter a compat_symbol (BZ#17726)

[Adhemerval Zanella <adhemerval dot zanella at linaro dot org>]

On 05/08/2019 06:53, Florian Weimer wrote:
> * Carlos O'Donell:
> 
>> On 8/2/19 3:55 PM, Joseph Myers wrote:
>>> On Fri, 2 Aug 2019, Adhemerval Zanella wrote:
>>>
>>>> So do you think we can remove them or should we keep them? I do think
>>>> we should just remove these accidental bleeding symbols.
>>>
>>> I think there is a strong presumption in favour of keeping symbols that
>>> were public in a (2.1 or later, i.e. after the introduction of symbol
>>> versioning) release, in the absence of clear evidence that the symbol
>>> would never have been usable.
>>
>> Agreed. Compat is safe enough.
> 
> I think Adhemerval's point is that it adds complexity because it
> requires support in the tree, for all architecturs, for something that
> would otherwise be unneeded.  If we can avoid that, it's a win for us.

Also that this symbol export was not meant in first place, so it is unlikely
programs uses it.  And if it were, it likely they either need to reference
to glibc implementation to get the correct prototype or it is bleeding in
application namespace wrongly, which is most likely.