This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Restore r31 setting in powerpc32 swapcontext

From: Carlos O'Donell <carlos at redhat dot com>
To: Florian Weimer <fweimer at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org, adhemerval dot zanella at linaro dot org, tuliom at linux dot ibm dot com
Date: Tue, 30 Jul 2019 09:54:12 -0400
Subject: Re: Restore r31 setting in powerpc32 swapcontext
References: <alpine.DEB.2.21.1907300047220.1468@digraph.polyomino.org.uk> <87o91cxa7x.fsf@oldenburg2.str.redhat.com>

On 7/30/19 3:17 AM, Florian Weimer wrote:

* Joseph Myers:

diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S b/sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S
index efebb10bba..6fa1ab7d6e 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/swapcontext-common.S
@@ -276,6 +276,9 @@ ENTRY(__CONTEXT_FUNC_NAME)
  	cmpwi	r3,0
  	bne	3f	/* L(error_exit) */

+ lwz r4,_FRAME_PARM_SAVE2(r1)

+	lwz	r31,_UC_REGS_PTR(r4)
+
  #ifdef __CONTEXT_ENABLE_FPRS
  # ifdef __CONTEXT_ENABLE_VRS


Patch looks good to me.  Carlos will have to ack it as the RM, though.


Please commit to master.

Fixing release regressions like this is the highest priority.

--
Cheers,
Carlos.

References:
- Restore r31 setting in powerpc32 swapcontext
  - From: Joseph Myers
- Re: Restore r31 setting in powerpc32 swapcontext
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]