This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Linux: Move getdents64 to <dirent.h>
* Carlos O'Donell:
> On 7/25/19 9:42 AM, Florian Weimer wrote:
>> This matches the location of the declaration in musl.
>>
>> [Passed testing on x86_64-linux-gnu, i686-linux-gnu, and
>> build-many-glibcs.py (with GCC 9). I do think we should make this
>> change before the release because it's going to be the first one with
>> getdents64.]
>>
>> 2019-07-25 Florian Weimer <fweimer@redhat.com>
>>
>> Linux: Move declaration of getdents64 to <dirent.h>.
>> * bits/dirent_ext.h: New file.
>> * dirent/Makefile (headers): Add bits/dirent_ext.h.
>> * dirent/dirent.h: Include <bits/dirent_ext.h>.
>> * sysdeps/unix/sysv/linux/bits/dirent_ext.h: New file.
>> * sysdeps/unix/sysv/linux/bits/unistd_ext.h (getdents64): Remove
>> declaration.
>> * manual/filesys.texi (Low-level Directory Access): Update header
>> to dirent.h.
>
> Adhemerval already reviewed this, but I double checked it also because
> we are trying to make sure we don't make any mistakes here.
>
> Please commit this immediately for master so the release goes out with
> the interface definition in the expected header. This avoids having to
> update the linux man pages twice also when we later change the header
> location. I think unistd.h is just wrong for this Linux interface.
Thanks, pushed.
Florian