This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 13/25] Split up endian.h to minimize exposure of BYTE_ORDER.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: <libc-alpha at sourceware dot org>, <carlos at redhat dot com>
- Date: Wed, 24 Jul 2019 21:14:03 +0000
- Subject: Re: [PATCH 13/25] Split up endian.h to minimize exposure of BYTE_ORDER.
- References: <20190626175029.4699-1-zackw@panix.com> <20190626175029.4699-4-zackw@panix.com>
On Wed, 26 Jun 2019, Zack Weinberg wrote:
> - The C-SKY port does not fully support big-endian mode, but I do
> not think this is sufficient reason to make csky/bits/endian(ness).h
> error out if __CSKYBE__ is defined, so it now defines __BYTE_ORDER
> appropriately for whichever mode the compiler is in.
The general principle here is that we have a defined set of known ABIs
supported by glibc - and if the compiler might support some other ABI
variant that isn't properly supported by glibc (and doesn't have its own
dynamic linker name allocated in glibc, for example), we should ensure
that any attempt to build glibc for that ABI fails.
(The most friendly way to fail would probably be an error from the
preconfigure fragment rather than later when building some file including
some header using #error.)
--
Joseph S. Myers
joseph@codesourcery.com