Re: [PATCH] test-container: Install with $(all-subdirs) [BZ #24794]

[Stefan Liebler <stli at linux dot ibm dot com>]

Hi,

starting with this commit, I see the following fail:
cat nss/tst-nss-files-hosts-long.out
error: tst-nss-files-hosts-long.c:35: ahostsv4 failed
error: 1 test failures

Does anybody else also see this fail?

While running "make check" I've recognized the output of 
support/shell-container.c:
sh: execing getent failed: No such file or directory File
sh: execing /usr/bin/makedb failed: No such file or directory File

And indeed getent does not exist in <build-dir>/testroot.root or 
<build-dir>/testroot.pristine. Without this commit, it was available.

In older logs, I've found these commands:
/usr/bin/install -c build/nss/getent 
build/testroot.pristine/usr/bin/getent.new
/usr/bin/install -c build/nss/makedb 
build/testroot.pristine/usr/bin/makedb.new
mv -f build/testroot.pristine/usr/bin/getent.new 
build/testroot.pristine/usr/bin/getent
mv -f build/testroot.pristine/usr/bin/makedb.new 
build/testroot.pristine/usr/bin/makedb

Can anybody help?

Bye
Stefan

On 7/23/19 6:29 PM, Tulio Magno Quites Machado Filho wrote:
> DJ Delorie <dj@redhat.com> writes:
>
> > Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> writes:
> > > Whenever a sub-make is created, it inherits the variable subdirs from its
> > > parent.  This is also true when make check is called with a restricted
> > > list of subdirs.  In this scenario, make install is executed "partially"
> > > and testroot.pristine ends up with an incomplete installation.
> >
> > "obvious in retrospect"  Sigh.
> >
> > > 2019-07-22  Tulio Magno Quites Machado Filho  <tuliom@linux.ibm.com>
> > >
> > > 	[BZ #24794]
> > > 	* Makefile (testroot.pristine/install.stamp): Pass
> > > 	subdirs='$(all-subdirs)' to make install.
> >
> > LGTM.  Thanks!
> >
> > Reviewed-by: DJ Delorie <dj@redhat.com>
>
> Pushed as 35e038c1d2ccb.
>
> Thanks!