Re: [PATCH] Added International_Standard_Book_Number (ISBN) for various Locales

[Rafal Luzynski <digitalfreak at lingonborough dot com>]

Hello,

Thank you for your contribution, and thank you for posting it here
at libc-alpha.  Please see below:

19.07.2019 12:39 Sai Charan Sane <s.charan@samsung.com> wrote:
> 
> 
> From: Akhilesh Kumar <akhilesh.k@samsung.com>
> 
> [BZ #24817]
> * locales/om_KE (LC_TIME): copy "om_ET".

This does not seem to be part of this patch (which is OK but
this line should be deleted).

> * locales/aa_ER  (LC_ADDRESS): Added country_isbn.

Alternatively I think it is OK if you mention (country_isbn) as
a new entry instead of (LC_ADDRESS).  But this is correct as well.

> * locales/aa_ET  (LC_ADDRESS): Added country_isbn.
> * locales/am_ET  (LC_ADDRESS): Added country_isbn.
> * locales/byn_ER  (LC_ADDRESS): Added country_isbn.
> * locales/gez_ER  (LC_ADDRESS): Added country_isbn.
> * locales/gez_ET  (LC_ADDRESS): Added country_isbn.
> * locales/om_ET  (LC_ADDRESS): Added country_isbn.
> * locales/sid_ET  (LC_ADDRESS): Added country_isbn.
> * locales/so_ET  (LC_ADDRESS): Added country_isbn.
> * locales/ti_ER  (LC_ADDRESS): Added country_isbn.
> * locales/ti_ET  (LC_ADDRESS): Added country_isbn.
> * locales/tig_ER  (LC_ADDRESS): Added country_isbn.
> * locales/wal_ET  (LC_ADDRESS): Added country_isbn.

Please use "Likewise." instead of the actual comment if it
is the same for all entries unless the comment is shorter than
"Likewise."

> [...]
> diff --git a/localedata/locales/aa_ER b/localedata/locales/aa_ER
> index 6d20ae9..ca49c22 100644
> --- a/localedata/locales/aa_ER
> +++ b/localedata/locales/aa_ER
> @@ -112,7 +112,7 @@ country_ab2   "ER"
>  country_ab3   "ERI"
>  country_num   232
>  country_car   "ER"
> -% country_isbn  unknown, Need ISO 2108
> +country_isbn  99948 

Please provide the source of this information.

>  lang_name     "Qafar"
>  lang_ab       "aa"
>  lang_term     "aar"
> diff --git a/localedata/locales/aa_ET b/localedata/locales/aa_ET
> index 93fcdb7..31bcf49 100644
> --- a/localedata/locales/aa_ET
> +++ b/localedata/locales/aa_ET
> @@ -112,7 +112,7 @@ country_ab2   "ET"
>  country_ab3   "ETH"
>  country_num   231   % 210 found in at least one ISO 3166 doc
>  country_car   "ETH"
> -% country_isbn  unknown, Need ISO 2108
> +country_isbn  99944  
> [...]

Likewise.

I have cut off the rest of the patch because the further parts provide
the same changes as mentioned above.

I don't see any missing locale in this patch.

Regards,

Rafal