This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[RFC v3 21/23] RISC-V: Fix llrint and llround missing exceptions on RV32
- From: Alistair Francis <alistair dot francis at wdc dot com>
- To: libc-alpha at sourceware dot org
- Cc: arnd at arndb dot de, adhemerval dot zanella at linaro dot org, fweimer at redhat dot com, palmer at sifive dot com, macro at wdc dot com, zongbox at gmail dot com, alistair dot francis at wdc dot com, alistair23 at gmail dot com
- Date: Tue, 16 Jul 2019 17:09:37 -0700
- Subject: [RFC v3 21/23] RISC-V: Fix llrint and llround missing exceptions on RV32
- Ironport-sdr: WAZic+3jOIQVuVZDoeS1R4YVpbhts92AqUJEyse8bSdXott+EJwggqBCXwj5S3ErHXREeg98FB bkuUH/BTQ7n7hKVkT6aNoVEr9T0wvR7TjuXaKGgxLTEo/cuunpVwLQ80UR/DRk9wbbFxTCV/7a eVzOJliOr0GGdd76xx3+sA6pqRwtk2coZwbJqgekdyBTzo4aP58aUMJTIVf+H4/+zylbfuGJeW mANLDXM4KSZDL4BdoNEf1JYSlP/wKl6opojFuhpDGlfQRJHPR1J2lTGlyYokleaCiJwIuC4Jcm lNg=
- Ironport-sdr: 1pvjZPkvVqAS0rQApUHWjhI6+sFHvnSUEK/1OHm1zUt1MtlVpq0hXp5FCa4eXImo/T6cLz+tKm K3jxjSXJ7wJuaXH1u9zj3xTTlQKP07hseIKqDKcv9EiDjLkuBZCp9CxL4zTExRoZ1VaWTObxji YV0rdAGt1ZhS273w/lyYmiAmnSv14T2eHvkdpKhBviLFsJ80phWvUsd8jDKTVJwGSO0fCcgruz IjJP8wZIUDFodg0ytjordal23Q9hmqLel5ixCvOiRP2I6rIEqGhD3yaLMbaRsS5px53ESYI0Cl oLbHKCXy0bfxj7nyWOJHLQY9
- Ironport-sdr: Q5xSgWdKpvCJZpH0taBPvWqoq/UhUX6x75F8qASNhGRt1FRS3iVtiWUz0Lrk0PLJwHDZ9PTrKD eptbeSrgLve1sIEWNMbHZTyqs2HuK18ijJCKxJkTA3gMf9pnOGUs8TASHpAnQ8I6Q4J+bpctl8 huy58EtT22q60wnyZj0RoPt6PW9szKwkggVsU7+ljdgt0RNoI9p0OLs52Hw8GEOtcEv2yLowde QYU3sSzOG38fZSS7VuPIc2I90jZ5nvi0Cn51PM3QY+/acECLIwMVwTyItY3waymdwRy5EgPXhA yU8=
- References: <cover.1563321715.git.alistair.francis@wdc.com>
From: Zong Li <zongbox@gmail.com>
Similar to the recent fix for MIPS, ARM and S/390, RV32 is missing
correct exception on overflow from llrint and llround functions because
cast from floating-point types to long long do not result in correct
exceptions on overflow.
2018-11-29 Zong Li <zong@andestech.com>
* sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h: New file.
---
ChangeLog | 10 +++++
.../riscv/rv32/fix-fp-int-convert-overflow.h | 38 +++++++++++++++++++
2 files changed, 48 insertions(+)
create mode 100644 sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
diff --git a/ChangeLog b/ChangeLog
index 131c1063fc..8b8b038b23 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1114,6 +1114,16 @@
* sysdeps/unix/sysv/linux/riscv/configure.ac: Likewise.
* sysdeps/unix/sysv/linux/riscv/shlib-versions: Likewise.
* sysdeps/riscv/preconfigure: Likewise.
+ * sysdeps/riscv/rv32/Implies-after: New file.
+ * sysdeps/riscv/rv32/rvd/Implies: Likewise.
+ * sysdeps/riscv/rv32/rvf/Implies: Likewise.
+ * sysdeps/unix/sysv/linux/riscv/rv32/Implies: Likewise.
+ * sysdeps/unix/sysv/linux/riscv/Makefile: Support rv32.
+ * sysdeps/unix/sysv/linux/riscv/configure: Likewise.
+ * sysdeps/unix/sysv/linux/riscv/configure.ac: Likewise.
+ * sysdeps/unix/sysv/linux/riscv/shlib-versions: Likewise.
+ * sysdeps/riscv/preconfigure: Likewise.
+ * sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h: New file.
2019-06-20 Dmitry V. Levin <ldv@altlinux.org>
Florian Weimer <fweimer@redhat.com>
diff --git a/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
new file mode 100644
index 0000000000..6b34a8415e
--- /dev/null
+++ b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
@@ -0,0 +1,38 @@
+/* Fix for conversion of floating point to integer overflow. ARM version.
+ Copyright (C) 2015-2018 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifndef FIX_FP_INT_CONVERT_OVERFLOW_H
+#define FIX_FP_INT_CONVERT_OVERFLOW_H 1
+
+/* As of GCC 5, the generic libgcc2.c conversions from floating point
+ to long long may not raise the correct exceptions on overflow (and
+ may raise spurious "inexact" exceptions even in non-overflow cases,
+ see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59412>). */
+#define FIX_FLT_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT_LLONG_CONVERT_OVERFLOW 1
+
+#define FIX_DBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_DBL_LLONG_CONVERT_OVERFLOW 1
+
+#define FIX_LDBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_LDBL_LLONG_CONVERT_OVERFLOW 0
+
+#define FIX_FLT128_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT128_LLONG_CONVERT_OVERFLOW 0
+
+#endif /* fix-fp-int-convert-overflow.h */
--
2.22.0