Re: [PATCH] [powerpc] fpu_control.h: protect use of __builtin_cpu_supports()

[Paul Clarke <pc at us dot ibm dot com>]

On 7/9/19 5:07 AM, Florian Weimer wrote:
> * Andreas Schwab:
>> On Jul 09 2019, Florian Weimer <fweimer@redhat.com> wrote:
>>> * Paul A. Clarke:
>>>>
>>>> Using __builtin_cpu_supports() requires support in GCC and Glibc.
>>>> My recent patch to fpu_control.h added an unprotected use of
>>>> __builtin_cpu_supports(), and this is a user-visible file.
>>>
>>> Are you sure?  I don't think it's an installed header, and that's what
>>> “user-visibile file” implies to me.
>>
>> It's in math/Makefile:headers.
> 
> fpu_control.h?  Yes.  But the changed file is
> sysdeps/powerpc/fpu/fenv_libc.h, which I don't think is installed.

Ugh.  You're both right, of course.  Why I got fpu_control.h stuck in my brain, who knows?

Thank you for your comments.

Let me send a better version of this patch.

PC