This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] NEWS: clarify copy_file_range
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: DJ Delorie <dj at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 02 Jul 2019 21:19:44 +0200
- Subject: Re: [patch] NEWS: clarify copy_file_range
- References: <xnwoh0s0t4.fsf@greed.delorie.com>
* DJ Delorie:
> Florian asked me for feedback wrt this discussion:
> https://lists.gnu.org/archive/html/bug-gnulib/2019-06/msg00109.html
>
> I propose a slight re-wording of NEWS to clarify what applications
> must do wrt the copy_file_range change:
>
> diff --git a/NEWS b/NEWS
> index 6c7de105ac..11099f7248 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -46,9 +46,11 @@ Deprecated and removed features, and other changes affecting compatibility:
> support the system call of the same name. Previously, user space
> emulation was performed, but its behavior did not match the kernel
> behavior, which was deemed too confusing. Applications which use the
> - copy_file_range function will have to be run on kernels which implement
> - the copy_file_range system call. Support for most architectures was added
> - in version 4.5 of the mainline Linux kernel.
> + copy_file_range function can no longer rely on glibc to provide a fallback
> + on kernels that do not support the copy_file_range system call, and if
> + this function returns ENOSYS, they will need to use their own fallback.
> + Support for copy_file_range for most architectures was added in version
> + 4.5 of the mainline Linux kernel.
Looks good to me. Thanks.