This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Cleanup: use actual power8 assembly mnemonics
On 02/07/2019 11:27, Gabriel F. T. Gomes wrote:
> On Mon, Jul 01 2019, Adhemerval Zanella wrote:
>>
>> I still think it is better to add an assembler check similar to the
>> compiler one on sysdeps/powerpc/powerpc64/le/configure.ac for the required
>> instructions.
>
> Although the idea of such a check sounds good to me, the check would be
> for xssqrtqp, an instruction that has *not* been added by this commit,
> but by an old commit (f819dbea0a58). So I think the addition of the
> check belongs in a different patch, because this patch works correctly
> with the current minimum binutils version, i.e. binutils-2.25.
>
> Does that sound good to you?
>
> Maybe I'm nitpicking (sorry if I am, it's not my intention) but I think
> that these problems are semantically independent and should be in
> different commits.
>
Sounds good. So to make it clear what may fail (not assuming backports)
is powerpc64le default multiarch with binutils-2.25 due xssqrtqp right?