This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Linux: Implement per-thread user and group IDs
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 01 Jul 2019 06:49:59 +0200
- Subject: Re: [PATCH] Linux: Implement per-thread user and group IDs
- References: <874l49mtgy.fsf@oldenburg2.str.redhat.com> <89eeb216-1332-a1fc-03aa-6eb8b8f9bbe6@redhat.com> <87k1d39zyy.fsf@mid.deneb.enyo.de> <b77c24ec-8393-5dd2-05d4-dd20f461d736@redhat.com>
* Carlos O'Donell:
>> We might have to use SIGSETXID for something else in the future (or
>> perhaps we already do). I would leave this as it is today.
>
> Can you expand on this?
>
> Today SIGSETXID is reserved explicitly for this use, and it's a per-process
> signal handler, so it's always active until you remove the last use of
> SIGSETXID by replacing it with a kernel mechanism for transitioning IDs.
I meant that we might want to use the signal broadcast for something else,
not just set*id calls.
>>>> +* Likewise, on Linux, threads can now be created in such a way that they
>>>
>>> s/Likewise, on/On/g
>>
>> There's a preceding NEWS entry with similar wording, so I thought the
>> “Likewise” would make sense here.
>
> Each news entry should stand on its own so it can be quoted, or so it makes
> sense when reading just one entry.
Okay, I'll change this.
>>>> +/* Set *SCOPE to PTHREAD_PER_PROCESS_NP or PTHREAD_PER_THREAD_NP,
>>>> + depending on the state of *ATTR. */
>>>
>>> Wrong comment.
>>>
>>>> +int pthread_attr_getperthreadids_np (const pthread_attr_t
>>>> *__restrict __attr,
>>>> + int *__restrict __scope)
>>>> + __THROW __nonnull ((1, 2));
>>>> +
>>
>> Sorry, wrong comment in what way?
>
> It says "Set ..." but this is the getter.
*SCOPE is an out parameter, so “Set” is correct? I can use “Copy … to
…” instead if that's clearer.