Re: [PATCH] io: Remove copy_file_range emulation

[Florian Weimer <fweimer at redhat dot com>]

* Adhemerval Zanella:

>> diff --git a/NEWS b/NEWS
>> index 8a2fecef47..3961715106 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -36,6 +36,13 @@ Major new features:
>>  
>>  Deprecated and removed features, and other changes affecting compatibility:
>>  
>> +* The copy_file_range function fails with ENOSYS if the kernel does not
>> +  support the system call of the same name.  Previously, user space
>> +  emulation was performed, but its behavior did not match the kernel
>> +  behavior, which was deemed too confusing.  Applications which use the
>> +  copy_file_range function will have to be run on kernels which implement
>> +  the copy_file_range system call.
>> +
>>  * The functions clock_gettime, clock_getres, clock_settime,
>>    clock_getcpuclockid, clock_nanosleep were removed from the librt library
>>    for new applications (on architectures which had them).  Instead, the
>
> Maybe add the minimum kernel version that implements the syscall is
> Linux 4.5.

I'm going to add this sentence to the NEWS entry:

  Support for most architectures was added in version 4.5 of the
  mainline Linux kernel.

> Do you plan to backport it to 2.27, 2.28, and/or 2.29?

I had not, but I now think we should do it.  I will also try to excise
it from our downstream releases.

> Michael, we will need to update the man pages. 
>
> LGTM with a nit below regarding a gratuitous extra line.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

Thanks, fixed the nit, and finally tests are running.

Florian