This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 21/28] powerpc: Refactor powerpc32 lround/lroundf/llround/llroundf
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 25 Jun 2019 15:44:05 -0300
- Subject: Re: [PATCH 21/28] powerpc: Refactor powerpc32 lround/lroundf/llround/llroundf
- References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-22-adhemerval.zanella@linaro.org> <20190624210726.nllhjjcdtruehpn6@tereshkova> <94c7d9c7-9f30-7a77-de52-6199b7d8cd29@linaro.org>
On Tue, Jun 25 2019, Adhemerval Zanella wrote:
>
> Without math_opt_barrier I am seeing with gcc 8.2.1 20190214
> (--build=powerpc64-unknown-linux-gnu --host=powerpc64-unknown-linux-gnu
> --target=powerpc-glibc-linux-gnu no extra option, built with
> build-many-glibcs.py) I see using the flags:
>
> powerpc-glibc-linux-gnu-gcc -mcpu=power4 ../sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_llround-power6.c -c -std=gnu11 -fgnu89-inline -g -O2 -mcpu=power4 -Wall -Wwrite-strings -Wundef -Werror -fmerge-all-constants -frounding-math -fno-stack-protector -mhard-float -Wstrict-prototypes -Wold-style-definition -fno-math-errno -mlong-double-128 -mcpu=power6 -D__NO_MATH_INLINES -D__LIBC_INTERNAL_MATH_INLINES
>
> ---
> __llround_power6:
> .LVL0:
> .LFB46:
> .file 1 "../sysdeps/powerpc/powerpc32/fpu/s_llround.c"
> .loc 1 33 1 view -0
> .cfi_startproc
> .loc 1 35 3 view .LVU1
> .loc 1 35 10 is_stmt 0 view .LVU2
> b llround
> .LVL1:
> .loc 1 35 10 view .LVU3
> .cfi_endproc
> ---
Oh, I see. Thank you for the details! :)
The patch looks good to me.
Reviewed-by: Gabriel F. T. Gomes <gabrielftg@linux.ibm.com>