This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl: Remove cancellation checks from sem_{timed}wait (BZ #23006)
- From: Florian Weimer <fweimer at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 24 Jun 2019 19:17:31 +0200
- Subject: Re: [PATCH] nptl: Remove cancellation checks from sem_{timed}wait (BZ #23006)
- References: <20190624170216.26723-1-adhemerval.zanella@linaro.org>
* Adhemerval Zanella:
> The Austin group has decided that sem_wait and sem_timedwait do not need to
> be cancellation points. This patch removes the cancellation checks in order
> to improve performance.
>
> As for comment #2 in BZ#23006, the old implementation which explicit check
> for cancellation is moved to a compat symbol.
The code nptl/sem_waitcommon.c still acts on a cancellation request, I
think. The only change is that if we do not wait at all, we do not act
on the cancellation. I don't think this matches the POSIX semantics,
where cancellation points are either there or not, and do not depend on
function implementation details.
Thanks,
Florian