This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: nss_db: protect against empty mappings
- From: Andreas Schwab <schwab at suse dot de>
- To: DJ Delorie <dj at redhat dot com>
- Cc: fweimer at redhat dot com, carlos at redhat dot com, libc-alpha at sourceware dot org
- Date: Mon, 24 Jun 2019 10:19:12 +0200
- Subject: Re: nss_db: protect against empty mappings
- References: <xntvclbkqd.fsf@greed.delorie.com>
On Jun 19 2019, DJ Delorie <dj@redhat.com> wrote:
> Andreas Schwab <schwab@suse.de> writes:
>> If calling is_selinux_enabled has side effects then it cannot be elided.
>> If it doesn't, then it is pointless. Assignment to a write-only
>> variable doesn't change that.
>
> Sorry, by "side effects" I meant "the program has a runtime dependency
> on selinux.so". The program is never run so it doesn't matter what the
> function *does*. The code is intentionally overcomplicated to ensure
> gcc doesn't optimize away the call, either now or in the future.
Then please add a comment that this call is only there to add a
dependency on libselinux.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."