This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nftw: fill in stat buf for dangling links [BZ #23501]
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: DJ Delorie <dj at redhat dot com>, tuliom at ascii dot art dot br, libc-alpha at sourceware dot org
- Date: Sun, 23 Jun 2019 14:13:18 +0200
- Subject: Re: [PATCH] nftw: fill in stat buf for dangling links [BZ #23501]
- References: <xnwohduj12.fsf@greed.delorie.com> <m2tvcg7p4o.fsf@linux-m68k.org>
* Andreas Schwab:
> On Jun 22 2019, DJ Delorie <dj@redhat.com> wrote:
>
>> Andreas Schwab <schwab@linux-m68k.org> writes:
>>> If it's ENOENT, you could just skip it.
>>
>> The existing code wouldn't skip it, so that would be a more significant
>> change.
>>
>> Unless you just mean skip filling in the stat_buf, but as I commented,
>> "Let's prefer obvious over subtle so zero the data here."
>
> Since the name no longer exists it should be treated like any other
> non-existing name.
I agree with Andreas. Skipping ENOENT is not really an observable
because its occurrence depends on a race condition anyway.