This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 3/6] nptl: Add POSIX-proposed pthread_cond_clockwait
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org, Mike Crowe <mac at mcrowe dot com>
- Date: Wed, 12 Jun 2019 17:22:22 -0300
- Subject: Re: [PATCH v3 3/6] nptl: Add POSIX-proposed pthread_cond_clockwait
- References: <cover.206947992e95511c1c56165c9aa98ae1a2296b75.1558987219.git-series.mac@mcrowe.com> <eca8a8e2415c1e6b47f9551a6048931282f5b78e.1558987219.git-series.mac@mcrowe.com> <effa8cc7-0760-e381-d931-a40fbd0b372f@linaro.org>
On 06/06/2019 09:53, Adhemerval Zanella wrote:
>
>
> On 27/05/2019 17:03, Mike Crowe wrote:
>> Add:
>>
>> int pthread_cond_clockwait (pthread_cond_t *cond,
>> pthread_mutex_t *mutex,
>> clockid_t clockid,
>> const struct timespec *abstime)
>>
>> which behaves just like pthread_cond_timedwait except it always measures
>> abstime against the supplied clockid. Currently supports CLOCK_REALTIME and
>> CLOCK_MONOTONIC and returns EINVAL if any other clock is specified.
>>
>> Includes feedback from many others. This function was originally
>> proposed[1] as pthread_cond_timedwaitonclock_np, but The Austin Group
>> preferred the new name.
>
> For an initial implementation we will need to use a possible non reserved
> name, like pthread_cond_clockwait_np. Wehen Austin Group finally add this
> on standard we can then add an alias with an update to abilist.
It seems that there is no need to actually use a non future reserved name,
so I withdrew this suggestion.
>>
>> * manual/threads.texi: Document pthread_cond_clockwait. The comment
>> was provided by Carlos O'Donell.
>>
>> [1] https://sourceware.org/ml/libc-alpha/2015-07/msg00193.html
>
> For this addition we will also need a NEWS entry.
I missed the last patch in the set where it indeed adds a NEWS entry.
So I think it would be fine without a NEWS entry for this patch.