This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 17/28] powerpc: Remove optimized finite
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 11 Jun 2019 15:08:50 -0300
- Subject: Re: [PATCH 17/28] powerpc: Remove optimized finite
- References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-18-adhemerval.zanella@linaro.org>
On Fri, Mar 29 2019, Adhemerval Zanella wrote:
> The powerpc finite optimization do not show much gain:
>
> - The power7 uses ftdiv to optimize for some input patterns, but at
> cost of others. Comparing against generic C implementation built
> for powerpc64-linux-gnu-power7 (--with-cpu=power7):
>
> [...]
>
> So it basically optimizes marginally for normal numbers while
> increasing the latency for other kind of FP.
Fair enough.
> * sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile
> (sysdeps_routines, libm-sysdep_routines): Remove s_finite*
> objects.
> * sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_finite-power7.S:
> Remove file.
> * sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_finite-ppc32.c:
> Likewise.
> * sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_finite.c: Likewise.
> * sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_finitef-ppc32.c:
> Likewise.
> * sysdeps/powerpc/powerpc32/power4/fpu/multiarch/s_finitef.c: Likewise.
> * sysdeps/powerpc/powerpc32/power7/fpu/s_finite.S: Likewise.
> * sysdeps/powerpc/powerpc32/power7/fpu/s_finitef.S: Likewise.
> * sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile usysdep_call):
^
Typo................................................. here ^
> Likewise.
"Remove s_finite* objects"?
This patch looks good to me.
Reviewed-by: Gabriel F. T. Gomes <gabrielftg@linux.ibm.com>