This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 15/28] powerpc: Remove optimized isinf
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 11 Jun 2019 10:45:19 -0300
- Subject: Re: [PATCH 15/28] powerpc: Remove optimized isinf
- References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-16-adhemerval.zanella@linaro.org>
On Fri, Mar 29 2019, Adhemerval Zanella wrote:
>
> - The power7 uses ftdiv to optimize for some input pattern and branch
> implementation for INF and denormal that does:
>
> return (ix & UINT64_C (0x7fffffffffffffff)) == UINT64_C (0x7ff0000000000000)
>
> Although it does show slight better latency than generic algorithm,
> it is only for power7 and requires it to override it for power8.
Fair enough.
> * sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile usysdep_call):
^
Typo................................................. here ^
> Likewise.
~~~~~~~~
"Remove s_isinf* objects"?
This patch looks good to me, provided we have the previous patch
(<https://sourceware.org/ml/libc-alpha/2019-03/msg00660.html>), or some
alternative implementation merged, as well.
Reviewed-by: Gabriel F. T. Gomes <gabrielftg@linux.ibm.com>