Re: [PATCH v6] y2038: Introduce __ASSUME_TIME64_SYSCALLS define

[Lukasz Majewski <lukma at denx dot de>]

Hi Joseph,

> On Fri, 7 Jun 2019, Lukasz Majewski wrote:
> 
> > > __ASSUME_TIME64_SYSCALLS should have the simplest, clearest
> > > semantics that work for its purpose.  If any syscall needs
> > > something slightly different, it's appropriate to separate it
> > > out.  That includes if the previous versions of any of the other
> > > syscalls listed for __ASSUME_TIME64_SYSCALLS were not in fact
> > > present in 3.2 for all architectures supported by glibc
> > > (something I haven't checked, but which needs to be checked) - if
> > > any syscall has that as a complication, take it out of the list
> > > to which __ASSUME_TIME64_SYSCALLS applies and deal with that
> > > complication separately, later.
> > >   
> > 
> > Can we assume the above sentence as a "consensus" for
> > __ASSUME_TIME64_SYSCALLS semantics definition ?  
> 
> Whether or not there is consensus on it, it should be clear that a 
> detailed review will be needed to establish whether every syscall
> listed was indeed present in 3.2 (or the first kernel version
> supported by glibc for an architecture, if later) 

If I understood you correctly - the "syscall" - for example
clock_settime (with either 32 or 64 bit ABI) needs to be defined in
kernel 3.2 (the oldest supported kernel).

If it is not defined (or has different implementation), then it is
excluded from the list of syscalls eligible to __ASSUME_TIME64_SYSCALLS?


> for all glibc architectures.
> 

I'm a bit puzzled with the above sentence. We now focus on Linux
implementation - for example __ASSUME_TIME64_SYSCALLS is defined in:
sysdeps/unix/sysv/linux/kernel-features.h

Do you mean by "all glibc architectures" - all the architectures
supported by Linux kernel?

Was there previously any similar flag defined in a way similar to
__ASSUME_TIME64_SYSCALLS ? I would like to have a reference.




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgpICUt3iaMt8.pgp
Description: OpenPGP digital signature