Re: [PATCH] nl_NL locale: Correct the negative monetary format (bug 24614).

[Rafal Luzynski <digitalfreak at lingonborough dot com>]

7.06.2019 09:58 Florian Weimer <fweimer@redhat.com> wrote:
> 
> * Rafal Luzynski:
> 
> > diff --git a/stdlib/tst-strfmon_l.c b/stdlib/tst-strfmon_l.c
> > index a193ed6787..7f0f6d47d5 100644
> > --- a/stdlib/tst-strfmon_l.c
> > +++ b/stdlib/tst-strfmon_l.c
> > @@ -216,6 +216,19 @@ static const struct locale_pair tests[] =
> > [...]
> 
> Originally, this test was intended as a test for strfmon_l, in
> particular that the locale argument controls all aspects of the
> formatting, and not just a subset.  It is not a general-purpose locale
> test.

Thank you for this feedback, I did not know.

> For locale testing, we should perhaps iterate through all supported
> locales and check against test expectations for number and money
> formatting.  I don't think we do that today.

There is another test program: localedata/tst-strfmon1.c.  I thought
that those two should be merged but now I guess that you would prefer
to have the test case added to localedata/tst-strfmon1.c instead of
to stdlib/tst-strfmon_l.c.

I don't think we are going to test *all* locales.  The collation tests
are huge and cover many locales but definitely not all.

Regards,

Rafal