This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] riscv: Do not use __has_include__
- From: Florian Weimer <fweimer at redhat dot com>
- To: Palmer Dabbelt <palmer at sifive dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 06 Jun 2019 09:58:56 +0200
- Subject: Re: [PATCH] riscv: Do not use __has_include__
- References: <mhng-9ecf96bb-ceaf-4469-9977-bafe2b82a146@palmer-si-x1c4>
* Palmer Dabbelt:
> On Wed, 05 Jun 2019 06:42:50 PDT (-0700), fweimer@redhat.com wrote:
>> The user-visible preprocessor construct is called __has_include.
>>
>> 2019-06-05 Florian Weimer <fweimer@redhat.com>
>>
>> * sysdeps/unix/sysv/linux/riscv/flush-icache.c: Do not use
>> internal GCC preprocessor identifier __has_include__.
>>
>> diff --git a/sysdeps/unix/sysv/linux/riscv/flush-icache.c b/sysdeps/unix/sysv/linux/riscv/flush-icache.c
>> index cd5c400977..f2dfcc50d0 100644
>> --- a/sysdeps/unix/sysv/linux/riscv/flush-icache.c
>> +++ b/sysdeps/unix/sysv/linux/riscv/flush-icache.c
>> @@ -21,7 +21,7 @@
>> #include <stdlib.h>
>> #include <atomic.h>
>> #include <sys/cachectl.h>
>> -#if __has_include__ (<asm/syscalls.h>)
>> +#if __has_include (<asm/syscalls.h>)
>> # include <asm/syscalls.h>
>> #else
>> # include <asm/unistd.h>
>
> Thanks!
I'll consider this a review and push this later. 8-)
Florian