This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH glibc 1/2] aarch64: add STO_AARCH64_VARIANT_PCS and DT_AARCH64_VARIANT_PCS
- From: Florian Weimer <fweimer at redhat dot com>
- To: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- Cc: "libc-alpha\@sourceware.org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Mon, 03 Jun 2019 19:26:11 +0200
- Subject: Re: [PATCH glibc 1/2] aarch64: add STO_AARCH64_VARIANT_PCS and DT_AARCH64_VARIANT_PCS
- References: <3c35b5f5-b13b-5e75-f0ed-2cbf788d83cf@arm.com> <84aa1cdf-c988-fdba-0628-ae9d242dc8ca@arm.com> <4d847962-1224-7d10-b772-b6cba19f8071@arm.com>
* Szabolcs Nagy:
> On 23/05/2019 12:19, Szabolcs Nagy wrote:
>> STO_AARCH64_VARIANT_PCS is a non-visibility st_other flag for marking
>> symbols that reference functions that may follow a variant PCS with
>> different register usage convention from the base PCS.
>>
>> DT_AARCH64_VARIANT_PCS is a dynamic tag that marks ELF modules that
>> have R_*_JUMP_SLOT relocations for symbols marked with
>> STO_AARCH64_VARIANT_PCS (i.e. have variant PCS calls via a PLT).
>>
>> 2019-05-22 Szabolcs Nagy <szabolcs.nagy@arm.com>
>>
>> * elf/elf.h (STO_AARCH64_VARIANT_PCS): Define.
>> (DT_AARCH64_VARIANT_PCS): Define.
>>
>
>
> i'd like to commit this patchset, but it modifies public elf.h
>
> i assume it is ok to commit now that the same definitions are
> in binutils.
>
> if there are no complaints i'll push the patches tomorrow.
I've already told you to use a new relocation type for this.
If you do not do this now, you *will* cause problems down the road.
Thanks,
Florian