This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH
- From: Carlos O'Donell <carlos at redhat dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: fweimer at redhat dot com, libc-alpha at sourceware dot org
- Date: Fri, 24 May 2019 00:05:10 -0400
- Subject: Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH
- References: <xnzhndgdeq.fsf@greed.delorie.com>
On 5/23/19 2:48 PM, DJ Delorie wrote:
>
> "Carlos O'Donell" <carlos@redhat.com> writes:
>> I would suggest that test-in-container's initial environment
>> should be as clean as possible, free of any host environment
>> variables.
>
> I don't feel particularly strongly about this as long as my concerns are
> heard, although if we want a clean environment, we're back to filtering
> inside test-container.c itself, since "just don't set it" won't stop the
> user environment from leaking into the container.
Correct. I believe we even discussed this during the initial design, and
rejected it as a non-goal for the first implementation.
I'm OK with filtering directly in test-container.c to leave a clean
environment for the program under test. Somebody needs to implement
that though. Are you volunteering for that Florian? :-)
--
Cheers,
Carlos.