This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [glibc] sysvipc: Consolidate semtimedop s390
- From: Florian Weimer <fweimer at redhat dot com>
- To: Adhemerval Zanella <azanella at sourceware dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 21 May 2019 08:30:34 +0200
- Subject: Re: [glibc] sysvipc: Consolidate semtimedop s390
- References: <20190520155729.96805.qmail@sourceware.org>
* Adhemerval Zanella:
> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=236c18e5683028d41c2721a8b1ec45c56c953d95
>
> commit 236c18e5683028d41c2721a8b1ec45c56c953d95
> Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> Date: Wed May 15 10:23:49 2019 -0300
>
> sysvipc: Consolidate semtimedop s390
>
> This patch consolidates the s390-32 semtimedop implementation by defining
> a arch-specific SEMTIMEDOP_IPC_ARGS to rearrange the arguments expected
> by s390 Linux kABI. The idea is to avoid have multiples semtimedop
> implementation changes for Linux v5.1 change to enable wire-up sysvipc
> support.
>
> Checked with a s390-linux-gnu and s390x-linux-gnu and checking that
> resulting semtimedop objects did not change.
>
> * sysdeps/unix/sysv/linux/ipc_priv.h (SEMTIMEDOP_IPC_ARGS): New
> define.
> * sysdpes/unix/sysv/linux/s390/ipc_priv.h: New file.
> * sysdeps/unix/sysv/linux/s390/semtimedop.c: Remove file.
> * sysdeps/unix/sysv/linux/semtimedop.c (semtimedop): Use
> SEMTIMEDOP_IPC_ARGS for calls with __NR_ipc.
This seems to have caused
../sysdeps/unix/sysv/linux/semtimedop.c: In function ‘semtimedop’:
../sysdeps/unix/sysv/linux/semtimedop.c:34:10: error: implicit declaration of function ‘SEMTIMEDOP_IPC_ARGS’ [-Werror=implicit-function-declaration]
SEMTIMEDOP_IPC_ARGS (nsops, sops, timeout));
^~~~~~~~~~~~~~~~~~~
on powerpc-linux-gnu (and some others).
I'm not sure how this is supposed to work, given that ipc_priv.h has
sysdeps overrides and only the gneric and s390 were updated in this
commit.
Thanks,
Florian